Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify loopback size #8798

Merged
merged 1 commit into from Jul 10, 2023
Merged

Modify loopback size #8798

merged 1 commit into from Jul 10, 2023

Conversation

Jenkins-J
Copy link
Contributor

@Jenkins-J Jenkins-J commented Jul 10, 2023 •
edited

Modify the loopback size in the blockfile snapshotter test setup. Set the loopback size to 16MB when the page size is greater than 4096. This prevents smaller storage devices from running out of free space while the test is running. Addresses issue #8767.

@k8s-ci-robot
Copy link

Hi @Jenkins-J. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fuweid
Copy link
Contributor

fuweid commented Jul 10, 2023

@Jenkins-J would you mind to share the test result? just wonder that 16MiB is good enough for the test. Thanks

@Jenkins-J
Copy link
Contributor Author

@fuweid Here are the test results from the blockfile snapshotter testsuite. I ran the test with go test -v -test.root -run TestBlockfile. If there are any other tests you'd like me to run or a better way to execute the testsuite, let me know.
blockfile-testsuite.txt

@Jenkins-J
Modify loopback size
5c480d9 
Modify the loopback size in the blockfile snapshotter test setup.
Set the loopback size to 16MB when the page size is greater than 4096.

Signed-off-by: James Jenkins <James.Jenkins@ibm.com>
fuweid
fuweid approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@fuweid fuweid linked an issue Jul 10, 2023 that may be closed by this pull request
Blockfile testsuite failure due to page size #8767
Closed
@kzys kzys merged commit f1d2868 into containerd:main Jul 10, 2023
43 checks passed
@Jenkins-J Jenkins-J deleted the blockfile-test-fix-rebase branch July 11, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzys kzys kzys approved these changes

@fuweid fuweid fuweid approved these changes

@dcantah dcantah dcantah approved these changes

Assignees
No one assigned
Labels
needs-ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blockfile testsuite failure due to page size
5 participants
@Jenkins-J @k8s-ci-robot @fuweid @kzys @dcantah