Uninstall mingw before attempting upgrade

[kiashok]

Update mingw after uninstall, similar to what is done in hccshimhttps://github.com/microsoft/hcsshim/blob/2feaacb46cf42e17ab81bfe6341d3529ef4cb897/.github/workflows/ci.yml#L421

[k8s-ci-robot]

Hi @kiashok. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kiashok]

cc @helsaawy @dmcgowan

[estesp]

Looks like a whitespace check failure in the commit git show --check will tell you, but looks like extra spaces on one of the lines after "shell: powershell" in your comment

[kzys]

LGTM. Re-running the failed tests.

[kiashok]

LGTM. Re-running the failed tests.

The tests are failing due to some mingw + golang version 1.20.3 issue that is causing some dll to not load. Looking at what the other options for us with WS2019 is. Also opened an issue for this in microsoft/go
microsoft/go#1081

[dagood]

I looked into this in more detail at microsoft/go#1081, but here's a summary:

• Updating MinGW is the right thing to do. The current build used in the win2019 image is from 2018 and the provider of this build has been removed from the list maintained at https://www.mingw-w64.org/downloads/.
• This PR isn't working because the Chocolatey installation isn't actually being used. The win2019 image has the outdated build's PATH entry before Chocolatey's PATH entry, so the outdated build is found regardless of what Chocolatey package is installed.

I see a couple ways forward in the short term:

• In addition to the Chocolatey version change, manipulate PATH to remove the outdated build, or delete the outdated build at C:\mingw64\bin entirely.
• Stop depending on Chocolatey and install MinGW yourself.
  • This involves downloading a 7z, verifying its checksum, extracting it (7z is installed on this image already), and prepending it to PATH.
  • https://github.com/niXman/mingw-builds-binaries/releases is the build provider used by GitHub Actions to build the win2022 image, and it works fine in my tests.

[dagood]

I filed an issue upstream to update MinGW in the image, and they think it's too risky, but provided a ready-made example of installing a newer MinGW in a workflow that you can use: actions/runner-images#9009 (comment).

[kiashok]

@jsturtevant @helsaawy @dagood @fuweid all the tests are passing. Could you please take a look?

[jsturtevant]

LGTM

[helsaawy]

LGTM

[estesp]

LGTM, but added one question on what appears to be an empty step (that may be required) but want to make sure I understand