Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.2.x] containerd: ignore SIGPIPE #930

Merged
merged 1 commit into from May 30, 2017

Conversation

@runcom
Copy link
Contributor

commented May 27, 2017

Fix #580

As already stated in moby/moby#19728, this is meant as a temporary workaround cause it's far worse to have dockerd/containerd silently go away. We have people working on a proper fix though.

Signed-off-by: Antonio Murdaca runcom@redhat.com

containerd: ignore SIGPIPE
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
@mlaventure
Copy link
Contributor

left a comment

LGTM

@mlaventure mlaventure added the v0.2.x label May 30, 2017

@crosbymichael

This comment has been minimized.

Copy link
Member

commented May 30, 2017

LGTM

@crosbymichael crosbymichael merged commit cfb82a8 into containerd:v0.2.x May 30, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@runcom runcom deleted the runcom:ignore-sigpipe-dockerd branch May 30, 2017

@andrewhsu andrewhsu referenced this pull request Jun 9, 2017
40 of 40 tasks complete
runcom added a commit to runcom/containerd that referenced this pull request Jun 27, 2017
containerd: main: notify on SIGPIPE
This PR containerd#930 ignored
SIGPIPE signals but we aren't actually subscribed to receive them (and
ignore them).
This patch adds the missing piece by subscribing to receive SIGPIPE(s).

Signed-off-by: Antonio Murdaca <runcom@redhat.com>
mlaventure added a commit to mlaventure/containerd that referenced this pull request Jul 4, 2017
containerd: main: notify on SIGPIPE
This PR containerd#930 ignored
SIGPIPE signals but we aren't actually subscribed to receive them (and
ignore them).
This patch adds the missing piece by subscribing to receive SIGPIPE(s).

Signed-off-by: Antonio Murdaca <runcom@redhat.com>
(cherry picked from commit 6a7b7d2)
Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
@estesp estesp referenced this pull request Jul 11, 2017
mlaventure added a commit to mlaventure/containerd that referenced this pull request Aug 7, 2017
containerd: main: notify on SIGPIPE
This PR containerd#930 ignored
SIGPIPE signals but we aren't actually subscribed to receive them (and
ignore them).
This patch adds the missing piece by subscribing to receive SIGPIPE(s).

Signed-off-by: Antonio Murdaca <runcom@redhat.com>
(cherry picked from commit 6a7b7d2)
Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.