containerd / continuity Public
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs: add WithAllowXAttrErrors CopyOpt #138
Conversation
cc @tonistiigi |
So the PR appeared to have nothing to do with the buildkit failure but should be still useful |
This option allows ignoring errors during copying xattr like `security.selinux`, which is not always supported. Reported in several issues including * openfaas/openfaas-cloud#312 * moby/buildkit#704 * genuinetools/img#45 * https://bugzilla.redhat.com/show_bug.cgi?id=1596918 Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Please consider this change on top of yours. It continues copying xattrs for a file, even if one of them fails (like Feel free to incorporate the modification in an updated PR. Thanks! |
@nixpanic Thanks, cherry-picked your commit |
Oh, nice! |
I think for this case, being able to pass in an error handler on file copy would be handy. Something like: func(err error) error Where if the handler wants to ignore the error it would return nil. |
Added |
Hey guys, any progress with reviewing/merging? This PR works well for me and I'd like to see it included so that I can consume it in kubernetes-retired/external-storage#1013 and a future CSI driver. Thanks! |
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
This option allows ignoring errors during copying xattr like
security.selinux
,which is not always supported.
Reported in several issues including
Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp