From ab84e3914db95df91f19223ca54e51d4d006f598 Mon Sep 17 00:00:00 2001
From: Hui Zhu <teawater@hyper.sh>
Date: Fri, 4 Jan 2019 09:19:24 +0800
Subject: [PATCH] Add integration test for RunPodSandbox and CreateContainer

Fixes: #1009

Signed-off-by: Hui Zhu <teawater@hyper.sh>
---
 integration/container_create_test.go | 40 ++++++++++++++++++++++++++++
 integration/sandbox_run_test.go      | 32 ++++++++++++++++++++++
 2 files changed, 72 insertions(+)
 create mode 100644 integration/container_create_test.go
 create mode 100644 integration/sandbox_run_test.go

diff --git a/integration/container_create_test.go b/integration/container_create_test.go
new file mode 100644
index 000000000..f222b274e
--- /dev/null
+++ b/integration/container_create_test.go
@@ -0,0 +1,40 @@
+/*
+Copyright 2018 The containerd Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package integration
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/require"
+	runtime "k8s.io/kubernetes/pkg/kubelet/apis/cri/runtime/v1alpha2"
+)
+
+func TestCreateContainerWithoutMetadata(t *testing.T) {
+	sbConfig := PodSandboxConfig("sandbox", "container-create")
+	sb, err := runtimeService.RunPodSandbox(sbConfig, *runtimeHandler)
+	require.NoError(t, err)
+	defer func() {
+		// Make sure the sandbox is cleaned up in any case.
+		runtimeService.StopPodSandbox(sb)
+		runtimeService.RemovePodSandbox(sb)
+	}()
+	config := &runtime.ContainerConfig{}
+	_, err = runtimeService.CreateContainer(sb, config, sbConfig)
+	require.Error(t, err)
+	_, err = runtimeService.Status()
+	require.NoError(t, err)
+}
diff --git a/integration/sandbox_run_test.go b/integration/sandbox_run_test.go
new file mode 100644
index 000000000..f7ee0a736
--- /dev/null
+++ b/integration/sandbox_run_test.go
@@ -0,0 +1,32 @@
+/*
+Copyright 2018 The containerd Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package integration
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/require"
+	runtime "k8s.io/kubernetes/pkg/kubelet/apis/cri/runtime/v1alpha2"
+)
+
+func TestRunPodSandboxWithoutMetadata(t *testing.T) {
+	sbConfig := &runtime.PodSandboxConfig{}
+	_, err := runtimeService.RunPodSandbox(sbConfig, *runtimeHandler)
+	require.Error(t, err)
+	_, err = runtimeService.Status()
+	require.NoError(t, err)
+}