Repository navigation
Expose underlying file's SyscallConn method. - #17
Merged
Merged
Conversation
Member
Author
|
ping @tonistiigi |
Member
|
What if the underlying file is not opened yet. Should we return a mock one that unblocks when the opened channel closes? |
Member
Author
|
Ah just realized there is the non-blocking open. |
cpuguy83
force-pushed
the
add_raw_conn
branch
from
January 15, 2019 01:03
f010780 to
f29a888
Compare
This allows raw access to the underlying FD, enabling things like in-kernel copy methods such as `splice` and `tee`. This interface was added to `*os.File` as part of go1.12beta2. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
add_raw_conn
branch
from
January 15, 2019 01:05
f29a888 to
094bd06
Compare
Member
Author
|
Updated, added new tests, updated CI to test on tip so that new tests will actually run. |
Member
Author
|
From travis run 😄
|
cpuguy83
force-pushed
the
add_raw_conn
branch
from
January 15, 2019 04:08
0f317bf to
26c9412
Compare
tonistiigi
reviewed
Jan 15, 2019
| default: | ||
| } | ||
|
|
||
| if !f.block { |
Member
There was a problem hiding this comment.
if block was true then either closed or opened has to be closed at this point. Otherwise, it wouldn't be possible to get a handle on the *fifo
|
|
||
| ready := make(chan struct{}) | ||
| close(ready) | ||
| return &rawConn{f: f, raw: raw, ready: ready}, nil |
Member
Author
There was a problem hiding this comment.
Are you saying we should just return f.file.SyscallConn in this case?
At the moment rawConn is doing some of the same things on read/write that *fifo does.
Member
There was a problem hiding this comment.
yes, if the file is already open it shouldn't matter and we can just use the file directly.
cpuguy83
force-pushed
the
add_raw_conn
branch
from
January 15, 2019 23:49
26c9412 to
8997a18
Compare
Makes sure that tests for raw conns are actually run in CI. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
add_raw_conn
branch
from
January 16, 2019 00:15
8997a18 to
e4b84c0
Compare
tonistiigi
approved these changes
Jan 16, 2019
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
Apr 14, 2019
- containerd/fifo#17 Expose underlying file's `SyscallConn` method Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Apr 16, 2019
- containerd/fifo#17 Expose underlying file's `SyscallConn` method Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 9234218c50dbe68e705fe0d48df718994ba97583 Component: engine
thaJeztah
added a commit
to thaJeztah/cli
that referenced
this pull request
Apr 18, 2019
- containerd/fifo#17 Expose underlying file's `SyscallConn` method Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Apr 18, 2019
- containerd/fifo#17 Expose underlying file's `SyscallConn` method Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: ac234326a69116c7a311911276cc4df58b2c5e0a Component: cli
tiborvass
pushed a commit
to tiborvass/cli
that referenced
this pull request
Apr 23, 2019
- containerd/fifo#17 Expose underlying file's `SyscallConn` method Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows raw access to the underlying FD, enabling things like
in-kernel copy methods such as
spliceandtee.This interface was added to
*os.Fileas part of go1.12beta2.