Repository navigation
feat: support for --sig-proxy in run - #3043
Merged
Merged
Conversation
Contributor
|
@CodeChanning this would be nice to have - thanks! |
Contributor
Author
Yes, I'm aiming to finish this change |
CodeChanning
force-pushed
the
sig-proxy_run
branch
3 times, most recently
from
June 12, 2024 22:39
720827b to
90995f9
Compare
CodeChanning
force-pushed
the
sig-proxy_run
branch
from
June 12, 2024 22:43
90995f9 to
7a949ba
Compare
CodeChanning
marked this pull request as ready for review
June 12, 2024 22:45
CodeChanning
force-pushed
the
sig-proxy_run
branch
2 times, most recently
from
June 12, 2024 23:45
13d0882 to
8bee996
Compare
Contributor
Author
|
Hi @apostasie, I believe my changes should be good for |
apostasie
reviewed
Jun 14, 2024
Contributor
Nothing obvious top of the head - I'll look into it and see if I can help. |
sondavidb
reviewed
Jun 17, 2024
CodeChanning
force-pushed
the
sig-proxy_run
branch
3 times, most recently
from
June 21, 2024 22:40
13355c5 to
23dedaa
Compare
AkihiroSuda
reviewed
Jun 24, 2024
| `--attach`, `--blkio-weight-device`, `--cpu-rt-*`, `--device-*`, | ||
| `--disable-content-trust`, `--domainname`, `--expose`, `--health-*`, `--isolation`, `--no-healthcheck`, | ||
| `--link*`, `--publish-all`, `--sig-proxy`, `--storage-opt`, | ||
| `--link*`, `--publish-all`, `--storage-opt`, |
Member
There was a problem hiding this comment.
Could you add the usage of sig-proxy?
Also, please squash the commits
CodeChanning
force-pushed
the
sig-proxy_run
branch
3 times, most recently
from
June 24, 2024 22:04
00601c1 to
a44deac
Compare
Signed-off-by: CodeChanning <chxgaddy@amazon.com>
CodeChanning
force-pushed
the
sig-proxy_run
branch
from
June 24, 2024 22:27
a44deac to
ae27768
Compare
CodeChanning
requested review from
AkihiroSuda,
Shubhranshu153,
apostasie and
sondavidb
June 24, 2024 23:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds support for the
--sig-proxy flaginnerdctl runandnerdctl attachAddress part of #3039
--sig-proxyexpected behavior:context:
src: docker attach documentation