Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remote: Support per-registry request headers #983

Merged
merged 1 commit into from Nov 9, 2022
Merged

remote: Support per-registry request headers #983

merged 1 commit into from Nov 9, 2022

Conversation

ktock
Copy link
Member

@ktock ktock commented Nov 8, 2022

header field allows to set headers to send to the server.

[[resolver.host."registry2:5000".mirrors]]
  host = "registry2:5000"
  [resolver.host."registry2:5000".mirrors.header]
    x-custom-2 = ["value3", "value4"]

NOTE: Headers aren't passed to the redirected location.

@ktock
remote: Support per-registry request headers
f38ad22 
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
@ktock ktock mentioned this pull request Nov 8, 2022
Closed
@ktock
Copy link
Member Author

ktock commented Nov 8, 2022

cc @gaius-qi

@gaius-qi
Copy link
Contributor

gaius-qi commented Nov 8, 2022

LGTM

@ktock ktock marked this pull request as ready for review November 8, 2022 08:07
@AkihiroSuda AkihiroSuda merged commit 40a3692 into containerd:main Nov 9, 2022
@ktock ktock deleted the header branch November 9, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ktock @gaius-qi @AkihiroSuda