plugins/main/ptp: support for creating tap devices #271
Conversation
| return "", fmt.Errorf("failed to generate random veth name: %v", err) | ||
| } | ||
|
|
||
| // NetworkManager (recent versions) will ignore veth devices that start with "veth" |
There was a problem hiding this comment.
This comment seems misleading in this place.
|
IMO this PR should be divided into 2 separate PRs - one with netlink update, second with changes for tap devices. Farther - with small comment correction - LGTM. |
|
Yeah, I agree, the netlink update is quite big and makes it more difficult to review code. |
* Moved tap creatin to ip/link package * Tap name is now generated similar to veth * Enabled libcni to create tap devices
|
This PR has been rebased after the merge of #274. |
|
LGTM |
|
@feiskyer @containernetworking/cni-maintainers PTAL |
|
Is it possible to add a test for this? |
lukasredynk
changed the title
|
@feiskyer I have added TAP device test for the ptp plugin. |
|
LGTM /cc @steveej |
|
This addition of the |
|
Yeah, but changes to input/output are less intrusive. Ok, I'll prepare changes to spec. As for version: 0.2.0 or 0.1.1? Given, that all fields added are purely optional I was thinking about 0.1.1. |
It's prototype code to move forward with discussion at #251
If non-empty CNI_VIRT is passed in env variable then instead of creating veth pair there's created tap interface and passed via iface field. Most of code changes here is related to updating netlink version, also in vendor clone I have to add additional codepath for specifying custom flags for tap creation.
Related PR: vishvananda/netlink#154