From cc6e8afa5ac53efcb4d3bb98251c4ce68ba50e49 Mon Sep 17 00:00:00 2001 From: Bruce Ma Date: Fri, 10 Jan 2020 20:36:12 +0800 Subject: [PATCH] pkg/utils: utility package should use black-box testing Signed-off-by: Bruce Ma --- pkg/utils/utils_test.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/pkg/utils/utils_test.go b/pkg/utils/utils_test.go index 002f8c82..2b97bcb5 100644 --- a/pkg/utils/utils_test.go +++ b/pkg/utils/utils_test.go @@ -12,13 +12,14 @@ // See the License for the specific language governing permissions and // limitations under the License. -package utils +package utils_test import ( "reflect" "testing" "github.com/containernetworking/cni/pkg/types" + "github.com/containernetworking/cni/pkg/utils" ) func TestValidateContainerID(t *testing.T) { @@ -45,7 +46,7 @@ func TestValidateContainerID(t *testing.T) { } for _, tt := range testData { - err := ValidateContainerID(tt.containerID) + err := utils.ValidateContainerID(tt.containerID) if !reflect.DeepEqual(tt.err, err) { t.Errorf("Expected '%v' but got '%v'", tt.err, err) } @@ -76,7 +77,7 @@ func TestValidateNetworkName(t *testing.T) { } for _, tt := range testData { - err := ValidateNetworkName(tt.networkName) + err := utils.ValidateNetworkName(tt.networkName) if !reflect.DeepEqual(tt.err, err) { t.Errorf("Expected '%v' but got '%v'", tt.err, err) } @@ -122,7 +123,7 @@ func TestValidateInterfaceName(t *testing.T) { } for _, tt := range testData { - err := ValidateInterfaceName(tt.interfaceName) + err := utils.ValidateInterfaceName(tt.interfaceName) if !reflect.DeepEqual(tt.err, err) { t.Errorf("Expected '%v' but got '%v'", tt.err, err) }