Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -hostprefix option #268

Merged

Conversation

Projects
None yet
3 participants
@s1061123
Copy link
Contributor

commented Feb 22, 2019

Fix #267

@bboreham

This comment has been minimized.

Copy link
Member

commented Mar 20, 2019

If we accept this change the documentation for this option would be incorrect.

daemonFlags.StringVar(&hostPrefix, "hostprefix", "", "optional prefix to netns")

If given `-hostprefix <prefix>` arguments after 'daemon', the dhcp plugin will use this prefix for netns as `<prefix>/<original netns>`. It could be used in case of running dhcp daemon as container.

Assuming you have good justification for the change (#267 merely asserts it should be this way), I suggest you change the documentation to match the new behaviour in this PR and add more background in the README.

@s1061123 s1061123 force-pushed the s1061123:fix/dhcp_daemon_hostprefix branch from 7c454a5 to 4ec62ac Mar 26, 2019

@s1061123

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

@bboreham thank you for your comments.
I will update diffs to incorporate your comments. Please take a look into it?

@s1061123

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

@bboreham second try. could you please take a look into it?

Show resolved Hide resolved plugins/ipam/dhcp/README.md Outdated
@bboreham
Copy link
Member

left a comment

LGTM

@squeed

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

lgtm

@squeed squeed merged commit fbd9acc into containernetworking:master Apr 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@s1061123 s1061123 deleted the s1061123:fix/dhcp_daemon_hostprefix branch Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.