Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins: correctly output build version, cosmetic cleanups #295

Merged
merged 2 commits into from Apr 17, 2019

Conversation

Projects
None yet
2 participants
@squeed
Copy link
Member

commented Apr 15, 2019

Now that libcni has the ability to print a version message, plumb it through correctly.

While we're at it,

  • fix import paths
  • run gofmt
  • add some more comments to sample
  • add container runtime swappability for release

Fixes: #101

@squeed squeed added this to the v0.8.0 milestone Apr 15, 2019

squeed added some commits Apr 15, 2019

plugins: correctly output build version, cosmetic cleanups
Now that libcni has the ability to print a version message, plumb it
through correctly.

While we're at it,
- fix import paths
- run gofmt
- add some more comments to sample
- add container runtime swappability for release
build_linux: don't build the sample plugin
It shouldn't be included in releases.

@squeed squeed force-pushed the squeed:buildversion branch from 47053a2 to 6ea047f Apr 15, 2019

@bboreham
Copy link
Member

left a comment

lgtm

@bboreham

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

Fixes one of the points at #277

@squeed squeed merged commit 5e25b0e into containernetworking:master Apr 17, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

invidian added a commit to invidian/kube-spawn that referenced this pull request May 21, 2019

pkg/cluster: remove 'sample' CNI file
CNI plugins 0.8.0 does not ship sample plugin anymore. It has been removed in
containernetworking/plugins#295, so we shouldn't
attempt to copy it.

Closes kinvolk#341

invidian added a commit to invidian/kube-spawn that referenced this pull request May 21, 2019

pkg/cluster: don't copy 'sample' CNI plugin
CNI plugins 0.8.0 does not ship 'sample' plugin anymore. It has been removed in
containernetworking/plugins#295, so we shouldn't
attempt to copy it.

Closes kinvolk#341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.