Allow to override build date with SOURCE_DATE_EPOCH #1805
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in order to make builds reproducible. See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable. This renames BUILD_INFO to the standard name so that distributions do not have to discover the BUILD_INFO variable, similar to cri-o/cri-o#2643 Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de>
|
@bmwiedemann Thanks for the PR! Our CI requires commits to be signed. If you did not do '-s' with your git commit, could you please do |
|
Can one of the admins verify this patch?
|
|
@TomSweeneyRedHat the commit has a Signed-off-by line (and a gpg sig). I just omitted in the PR message for readability. |
|
bot, add author to whitelist |
|
LGTM |
|
|
|
LGTM assuming happy tests, tyvm @bmwiedemann ! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Allow to override build date with
SOURCE_DATE_EPOCHin order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.
This renames
BUILD_INFOto the standard nameso that distributions do not have to discover the
BUILD_INFOvariable,similar to cri-o/cri-o#2643
This PR was done while working on reproducible builds for openSUSE.