Packit: custom action for copr rpm builds #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Packit jobs failed. @containers/packit-build please check. |
The COPR rpm builds done by packit fetch version using `git describe`. But this is a problem for the upgrade path from older copr builds because currently `git describe` fails on the monorepo. This commit adds a custom build script that sets rpm version from `common/version/version.go` . This will only affect COPR rpms and not official distro rpms. Similar action has been enabled on other projects already. Ref: https://github.com/containers/netavark/blob/main/.packit-copr-rpm.sh Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
Member
Author
|
copr rpms from this PR correctly show PTAL @containers/container-libs-maintainers |
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The COPR rpm builds done by packit fetch version using
git describe. But this is a problem for the upgrade path from older copr builds because currentlygit describefails on the monorepo.This commit adds a custom build script that sets rpm version from
common/version/version.go.This will only affect COPR rpms and not official distro rpms. Similar action has been enabled on other projects already.
Ref: https://github.com/containers/netavark/blob/main/.packit-copr-rpm.sh