Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unrecognized option '--keep' when using crun for building docker images #1428

Closed
ilfat12 opened this issue Mar 1, 2024 · 2 comments · Fixed by #1429
Closed

unrecognized option '--keep' when using crun for building docker images #1428

ilfat12 opened this issue Mar 1, 2024 · 2 comments · Fixed by #1429

Comments

@ilfat12
Copy link

ilfat12 commented Mar 1, 2024 •
edited
Loading

In version 0.12, buildkit (github.com/moby/buildkit) uses the --keep option with runc run during docker image builds, which is available in runc but not in crun. Therefore, I'm encountering an error. Would you be able to add a similar option for compatibility?

moby/buildkit#4721
This was referenced Mar 1, 2024
Closed
Closed
giuseppe added a commit to giuseppe/crun that referenced this issue Mar 1, 2024
@giuseppe
crun: add option --keep to run
8894495 
Closes: containers#1428

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe mentioned this issue Mar 1, 2024
Merged
@giuseppe
Copy link
Member

giuseppe commented Mar 1, 2024

could you please check if #1429 solve the problem you're seeing?

@ilfat12
Copy link
Author

ilfat12 commented Mar 1, 2024 •
edited
Loading

Hello @giuseppe, yes, it works fine. Thank you!

@thaJeztah thaJeztah mentioned this issue May 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

crun: add option --keep to run giuseppe/crun
2 participants
@giuseppe @ilfat12