Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for image/docker_schema1.go #144

Closed
mtrmac opened this issue Oct 31, 2016 · 3 comments
Closed

Add tests for image/docker_schema1.go #144

mtrmac opened this issue Oct 31, 2016 · 3 comments

Comments

@mtrmac
Copy link
Collaborator

mtrmac commented Oct 31, 2016

At least covering the success case for manifest conversion, like docker_schema2_test.go
giuseppe pushed a commit to giuseppe/image that referenced this issue Jan 24, 2017
@mtrmac
Merge pull request containers#144 from mtrmac/reference-abstraction
177463e 
Reference abstraction
@rhatdan
Copy link
Member

rhatdan commented Apr 25, 2019

@mtrmac @vrothberg What is the state of this issue. It is two years old, can we close it?

@vrothberg
Copy link
Member

There are tests now, so I think we can close the issue.

@mtrmac
Copy link
Collaborator Author

mtrmac commented Apr 25, 2019

Fixed in #416 for the record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rhatdan @mtrmac @vrothberg