registries.conf: prefixes: subdomain matching #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
TomSweeneyRedHat
reviewed
Mar 24, 2022
docs/containers-registries.conf.5.md
Outdated
| @@ -43,6 +43,8 @@ also include wildcarded subdomains in the format `*.example.com`. | |||
| The wildcard should only be present at the beginning as shown in the formats | |||
| above. Other cases will not work. For example, `*.example.com` is valid but | |||
| `example.*.com`, `*.example.com/foo` and `*.example.com:5000/foo/bar:baz` are not. | |||
| Note that `*` matches an arbitary number of subdomains. `*example.com` will hence | |||
| match `bar.example.com`, `foo.bar.example` and so on. | |||
There was a problem hiding this comment.
Suggested change
| match `bar.example.com`, `foo.bar.example` and so on. | |
| match `bar.example.com`, `foo.bar.example.com` and so on. |
|
One nit, otherwise LGTM |
Mention that wildcarded prefixes match an arbitrary number of subdomains. Closes: containers#1397 Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
mtrmac
reviewed
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Mention that wildcarded prefixes match an arbitrary number of
subdomains.
Closes: #1397
Signed-off-by: Valentin Rothberg vrothberg@redhat.com
@mtrmac @rhatdan PTAL