Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registries.conf: prefixes: subdomain matching #1505

Merged
merged 1 commit into from Mar 25, 2022

Conversation

vrothberg
Copy link
Member

@vrothberg vrothberg commented Mar 24, 2022

Mention that wildcarded prefixes match an arbitrary number of
subdomains.

Closes: #1397
Signed-off-by: Valentin Rothberg vrothberg@redhat.com

@mtrmac @rhatdan PTAL

@rhatdan
Copy link
Member

@rhatdan rhatdan commented Mar 24, 2022

LGTM
@TomSweeneyRedHat PTAL

mtrmac
mtrmac approved these changes Mar 24, 2022
Copy link
Contributor

@mtrmac mtrmac left a comment

LGTM. Thanks!

@@ -43,6 +43,8 @@ also include wildcarded subdomains in the format `*.example.com`.
The wildcard should only be present at the beginning as shown in the formats
above. Other cases will not work. For example, `*.example.com` is valid but
`example.*.com`, `*.example.com/foo` and `*.example.com:5000/foo/bar:baz` are not.
Note that `*` matches an arbitary number of subdomains. `*example.com` will hence
match `bar.example.com`, `foo.bar.example` and so on.
Copy link
Contributor

@TomSweeneyRedHat TomSweeneyRedHat Mar 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
match `bar.example.com`, `foo.bar.example` and so on.
match `bar.example.com`, `foo.bar.example.com` and so on.

Copy link
Member Author

@vrothberg vrothberg Mar 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching!

@TomSweeneyRedHat
Copy link
Contributor

@TomSweeneyRedHat TomSweeneyRedHat commented Mar 24, 2022

One nit, otherwise LGTM

Mention that wildcarded prefixes match an arbitrary number of
subdomains.

Closes: containers#1397
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
@vrothberg vrothberg merged commit 8c27ca2 into containers:main Mar 25, 2022
9 checks passed
@vrothberg vrothberg deleted the fix-1397 branch Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants