Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify the identity for signing #1510

Merged
merged 2 commits into from Mar 30, 2022

Conversation

Jamstah
Copy link
Contributor

@Jamstah Jamstah commented Mar 29, 2022

This enables pushing to registries where the push and pull uris may be
different, for example where pushed images are mirrored to a read only
replica for distribution.

Underpins implementation for containers/skopeo#1588

Copy link
Contributor

@mtrmac mtrmac left a comment

Thanks for taking this on!

copy/copy.go Outdated Show resolved Hide resolved
copy/sign.go Outdated Show resolved Hide resolved
Copy link
Contributor

@mtrmac mtrmac left a comment

Thanks! Code LGTM, one last nit.

copy/sign_test.go Show resolved Hide resolved
Jamstah added 2 commits Mar 30, 2022
This enables pushing to registries where the push and pull uris may be
different, for example where pushed images are mirrored to a read only
replica for distribution.

Underpins implementation for containers/skopeo#1588

Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
This ensures we never create an invalid signature.

Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
@Jamstah
Copy link
Contributor Author

@Jamstah Jamstah commented Mar 30, 2022

Rebased on latest main.

mtrmac
mtrmac approved these changes Mar 30, 2022
Copy link
Contributor

@mtrmac mtrmac left a comment

LGTM. Thanks again!

@mtrmac mtrmac merged commit fcf8dda into containers:main Mar 30, 2022
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants