Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to benefit from Go 1.16 #1521

Merged
merged 2 commits into from Apr 14, 2022
Merged

Update to benefit from Go 1.16 #1521

merged 2 commits into from Apr 14, 2022

Conversation

mtrmac
Copy link
Contributor

@mtrmac mtrmac commented Apr 13, 2022

After containers/storage#1176 requiring Go 1.16, c/image will effectively require Go 1.16 as soon as it updates to that version of c/storage; so, update as well.

This is mostly trivial updates to remove references io/ioutil, along with a few very small optimizations (ReadDir and WalkDir not calling lstat(2) on every entry).

@rhatdan
Copy link
Member

@rhatdan rhatdan commented Apr 13, 2022

LGTM

mtrmac added 2 commits Apr 13, 2022
Mostly just name changes that should not change behavior,
apart from ioutil.ReadDir -> os.ReadDir avoiding per-item
lstat(2) in some cases.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... to optimize away some lstat(2) calls.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Copy link
Member

@vrothberg vrothberg left a comment

LGTM

@vrothberg vrothberg merged commit d2d961d into containers:main Apr 14, 2022
9 checks passed
@mtrmac mtrmac deleted the go1.16 branch Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants