Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/containers/ocicrypt to 566b808 #1534

Merged
merged 1 commit into from Apr 29, 2022

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Apr 29, 2022

The two latest commits in c/ocicrypt get rid of OAEPDefaultHash envvar
and default to sha256.

They are waiting for confirmation on their rust side before cutting a
release. So, hoping to get this in assuming dependabot could take a
while.

Signed-off-by: Lokesh Mandvekar lsm5@fedoraproject.org

@mtrmac @vrothberg @rhatdan PTAL.

Copy link
Contributor

@mtrmac mtrmac left a comment

(I don’t think Dependabot is bringing in commits that aren’t a tagged release, at least in our configuration.)

LGTM. (This changes default behavior on encryption, but at least from the diff, no changes were necessary on the recipient side, so the new behavior should still be interoperable with older consumers.)

Thanks!

@mtrmac
Copy link
Contributor

@mtrmac mtrmac commented Apr 29, 2022

ERROR: Unknown/unsupported distro.   (contrib/cirrus/runner.sh:47 in _run_setup())

@cevich Does c/image need something like containers/skopeo#1631 ?

@cevich
Copy link
Contributor

@cevich cevich commented Apr 29, 2022

Yep, exactly. #1535

The two latest commits in c/ocicrypt get rid of OAEPDefaultHash envvar
and default to sha256.

They are waiting for confirmation on their rust side before cutting a
release. So, hoping to get this in assuming dependabot could take a
while.

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
@lsm5
Copy link
Member Author

@lsm5 lsm5 commented Apr 29, 2022

@mtrmac should be good to go now.

mtrmac
mtrmac approved these changes Apr 29, 2022
@mtrmac mtrmac merged commit f01b06f into containers:main Apr 29, 2022
9 checks passed
@lsm5 lsm5 deleted the main-bump-ocicrypt branch Apr 29, 2022
@lsm5
Copy link
Member Author

@lsm5 lsm5 commented Apr 29, 2022

@mtrmac is this worth a new version for dependabot's sake, or would you be cool if I vendor the commit into our usual tools? No rush of course, enjoy your weekend :)

@mtrmac
Copy link
Contributor

@mtrmac mtrmac commented Apr 29, 2022

@lsm5 I think @rhatdan is planning a vendor dance for start of next week – maybe you want it in the same timeframe for the same purpose?

If so, I’d prefer to wait until Monday to give others (and me, for #1533) a chance to get a perhaps some last-minute PRs in.

@mtrmac
Copy link
Contributor

@mtrmac mtrmac commented Apr 29, 2022

… WRT vendoring by commit, the code should be in good enough shape to do that if you want to e.g. benefit from it even in advance of that vendor dance.

@lsm5
Copy link
Member Author

@lsm5 lsm5 commented Apr 29, 2022

I'm cool with waiting, thanks a lot @mtrmac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants