-
Notifications
You must be signed in to change notification settings - Fork 189
feat(kiali): add Kiali trace details #478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c3efc63 to
dc2480a
Compare
|
Thanks! Just to clarify — before we add any new features, we really need to focus on reducing the number of tools and checking how the MCP behaves with the current setup. So for now, we should pause on adding anything else until we finish that cleanup and performance review. |
Should this be set on hold until we merge #496? @aljesusg @josunect |
|
Yes, it will be integrated into one of the existing tools after merge |
|
Hi @josunect . WE did the consolidation, these changes need to be applied in the tool kiali_get_traces |
Signed-off-by: josunect <jcordoba@redhat.com>
Signed-off-by: josunect <jcordoba@redhat.com>
Signed-off-by: josunect <jcordoba@redhat.com>
d5e9e45 to
f15345e
Compare
manusa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx Josune!
@aljesusg I'll defer to your review before merging.
aljesusg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGFM
Add toolset to check information about a trace: including all spans, timing details, and metadata for in-depth analysis. The trace ID can be obtained by any response from workload_traces, service_traces or app_traces.