Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve exited state across reboot #2273

Merged

Conversation

Projects
None yet
5 participants
@mheon
Copy link
Collaborator

commented Feb 5, 2019

Instead of unconditionally resetting to ContainerStateConfigured after a reboot, allow containers in the Exited state to remain there, preserving their exit code in podman ps after a reboot.

This does not affect the ability to use and restart containers after a reboot, as the Exited state can be used (mostly) interchangeably with Configured for starting and managing containers.

Much-delayed fix for #1703

Preserve exited state across reboot
Instead of unconditionally resetting to ContainerStateConfigured
after a reboot, allow containers in the Exited state to remain
there, preserving their exit code in podman ps after a reboot.

This does not affect the ability to use and restart containers
after a reboot, as the Exited state can be used (mostly)
interchangeably with Configured for starting and managing
containers.

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
@openshift-ci-robot

This comment has been minimized.

Copy link
Collaborator

commented Feb 5, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TomSweeneyRedHat

This comment has been minimized.

Copy link
Collaborator

commented Feb 6, 2019

Change LGTM, but tests aren't hip. Anyway to setup a test for this. Reboot part is hard to emulate in CI.
Regardless, looks like this had a registry test flake, I'll try to rekick.

@TomSweeneyRedHat

This comment has been minimized.

Copy link
Collaborator

commented Feb 6, 2019

bot, retest this please.

@mheon

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 6, 2019

bot, retest this please

@openshift-merge-robot

This comment has been minimized.

Copy link
Collaborator

commented Feb 6, 2019

/retest

@rhatdan

This comment has been minimized.

Copy link
Member

commented Feb 6, 2019

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit a9f75bf into containers:master Feb 6, 2019

14 checks passed

CAH 7-smoketested - Containerized (Podman in Docker) All tests passed.
Details
FAH28 - Containerized (Podman in Podman) All tests passed.
Details
build_each_commit Task Summary
Details
ci/prow/images Job succeeded.
Details
ci/prow/lint Job succeeded.
Details
ci/prow/validate Job succeeded.
Details
gating Task Summary
Details
required 2/2 PASSES
Details
success Task Summary
Details
testing image:fedora-28-libpod-7f4cd1f7 Task Summary
Details
testing image:fedora-29-libpod-7f4cd1f7 Task Summary
Details
testing image:rhel-7-libpod-7f4cd1f7 Task Summary
Details
testing image:ubuntu-18-libpod-7f4cd1f7 Task Summary
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.