Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reproducible builds in the Makefile #3390

Merged
merged 2 commits into from Jun 21, 2019

Conversation

Projects
None yet
7 participants
@Foxboron
Copy link
Contributor

commented Jun 20, 2019

Found two issues in the current Makefile where podman builds are not reproducible. There are several build times embedded to build artifacts, made sure these adhere to SOURCE_DATE_EPOCH. Builds paths are also trimmed with -gcflags and -asmflags so we can reproduce them without caring about build path differences.

https://reproducible-builds.org/

Foxboron added some commits Jun 20, 2019

Support SOURCE_DATE_EPOCH
Build artifacts embeds the current date of the build into the artifact.
If anyone want to reproduce the software at a later date there is no way
to pass a recorded date or fake it in the build system at a later point.

https://reproducible-builds.org/docs/source-date-epoch/

Signed-off-by: Morten Linderud <morten@linderud.pw>
Support Reproducible Builds by removing build path
An issue for achieving reproducible builds is build artifacts where
build paths are embedded. We remove them by passing the current working
directory to -gcflags and -asmflags which prefix trims the paths.

Note: Go 1.13 includes `-trimpath`

https://reproducible-builds.org/docs/build-path/

Signed-off-by: Morten Linderud <morten@linderud.pw>
@openshift-ci-robot

This comment has been minimized.

Copy link
Collaborator

commented Jun 20, 2019

Hi @Foxboron. Thanks for your PR.

I'm waiting for a containers or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rh-atomic-bot

This comment has been minimized.

Copy link
Collaborator

commented Jun 20, 2019

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once
@baude

This comment has been minimized.

Copy link
Collaborator

commented Jun 20, 2019

/ok-to-test

@mheon

This comment has been minimized.

Copy link
Collaborator

commented Jun 20, 2019

/approve

@openshift-ci-robot

This comment has been minimized.

Copy link
Collaborator

commented Jun 20, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Foxboron, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mheon

This comment has been minimized.

Copy link
Collaborator

commented Jun 20, 2019

Changes LGTM, but I'd like it if someone more familiar with makefiles could do a final review

@rhatdan

This comment has been minimized.

Copy link
Member

commented Jun 21, 2019

We don't have GO 1.13 in Fedora yet. But it looks like the tests are passing.

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit 39d6a86 into containers:master Jun 21, 2019

18 of 19 checks passed

tide Not mergeable.
Details
build_each_commit Task Summary
Details
ci/prow/images Job succeeded.
Details
ci/prow/lint Job succeeded.
Details
ci/prow/validate Job succeeded.
Details
gating Task Summary
Details
meta Task Summary
Details
special_testing_in_podman Task Summary
Details
special_testing_rootless TEST_REMOTE_CLIENT:false Task Summary
Details
special_testing_rootless TEST_REMOTE_CLIENT:true Task Summary
Details
success Task Summary
Details
testing TEST_REMOTE_CLIENT:false image:fedora-29-libpod-5156500369047552 Task Summary
Details
testing TEST_REMOTE_CLIENT:false image:fedora-30-libpod-5156500369047552 Task Summary
Details
testing TEST_REMOTE_CLIENT:false image:ubuntu-18-libpod-5156500369047552 Task Summary
Details
testing TEST_REMOTE_CLIENT:true image:fedora-29-libpod-5156500369047552 Task Summary
Details
testing TEST_REMOTE_CLIENT:true image:fedora-30-libpod-5156500369047552 Task Summary
Details
testing TEST_REMOTE_CLIENT:true image:ubuntu-18-libpod-5156500369047552 Task Summary
Details
varlink_api Task Summary
Details
vendor Task Summary
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.