Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add support for --env-host #3557
This flag passes the host environment into the container. The basic idea is to
Environment variables from the image, and passed in via --env and --env-file
Signed-off-by: Daniel J Walsh email@example.com
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rhatdan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
For what I am trying to do I only need variables with PMIX_ and OMPI_. If there is an option to specify the prefix it would also work. Having something which just passes everything into Podman would be the easiest. But I am happy with both ways (all variables or only some).
I will try this PR to see if it works for my mpirun use case.
Besides the broken test case this is exactly what I was looking for. Thanks.
I tried it and now I can run an Open MPI program (rootless) on a system without InfiniBand:
I am using ring.c from Open MPI: https://raw.githubusercontent.com/open-mpi/ompi/master/orte/test/mpi/ring.c
This also works for InfiniBand based system by including the InfiniBand devices into the container:
I am running my tests with OpenMPI 4.0.1 on RHEL 8.
Jul 12, 2019
21 of 22 checks passed
Thanks for the quick code changes. I mentioned this in my mail thread on the Open MPI user mailing list: https://firstname.lastname@example.org/msg33342.html
For completeness I also want to mention here that intra node communication based on shared memory still does not work with Podman and Open MPI. So currently I have to disable the shared memory transport layer in Open MPI by telling