Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix golint errors #4816

Merged
merged 11 commits into from Jan 8, 2020
Merged

Fix golint errors #4816

merged 11 commits into from Jan 8, 2020

Conversation

vrothberg
Copy link
Member

I wanted to enable golangci-lint for the test/ directory (which is currently not checked) and noticed that new errors were introduced to the rest of the code. I have no idea how that was possible but now the linter is happy again.

@giuseppe @mheon @baude @TomSweeneyRedHat @rhatdan PTAL

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L labels Jan 8, 2020
@vrothberg
Copy link
Member Author

Note that this PR is not enabling the linter for ./test. Something we can tackle later.

@mheon
Copy link
Member

mheon commented Jan 8, 2020

LGTM, but gating is angry

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Golint claims that image.Image stutters but renaming the type would be a
breaking change which isn't worth the consequences.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
@vrothberg
Copy link
Member Author

LGTM, but gating is angry

Should be happy now. Had some whitespaces in the commits :^)

@mheon
Copy link
Member

mheon commented Jan 8, 2020

Did we turn off branch protection? I have merge permission even though the PR isn't green yet

@vrothberg
Copy link
Member Author

Did we turn off branch protection? I have merge permission even though the PR isn't green yet

I see it too, but didn't notice before 🤔

@giuseppe giuseppe self-requested a review January 8, 2020 14:53
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TomSweeneyRedHat
Copy link
Member

LGTM assuming happy tests

@vrothberg
Copy link
Member Author

I assume these are flakes (for the record):

[+0925s] [Fail] Podman run with --sig-proxy [It] signals are not forwarded to container with sig-proxy false 
[+0925s] /var/tmp/go/src/github.com/containers/libpod/test/e2e/run_signal_test.go:135
[+0925s] 
[+0925s] [Fail] Podman run with --sig-proxy [It] signals are not forwarded to container with sig-proxy false 
[+0925s] /var/tmp/go/src/github.com/containers/libpod/test/e2e/run_signal_test.go:135
[+0925s] 
[+0925s] [Fail] Podman run with --sig-proxy [It] signals are not forwarded to container with sig-proxy false 
[+0925s] /var/tmp/go/src/github.com/containers/libpod/test/e2e/run_signal_test.go:135
[+0925s] 
[+0925s] [Fail] Podman network [It] podman network rm 
[+0925s] /var/tmp/go/src/github.com/containers/libpod/test/e2e/network_test.go:134

@vrothberg
Copy link
Member Author

I seem to be unable to restart the flaked test. Maybe someone else can try?

@vrothberg
Copy link
Member Author

Seems like an UI issue here. Jobs are running but the UI isn't updating. @cevich is investigating.

@rhatdan
Copy link
Member

rhatdan commented Jan 8, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2020
@openshift-merge-robot openshift-merge-robot merged commit c6ad42a into containers:master Jan 8, 2020
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants