New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix golint errors #4816
Fix golint errors #4816
Conversation
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Note that this PR is not enabling the linter for ./test. Something we can tackle later. |
LGTM, but gating is angry |
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Golint claims that image.Image stutters but renaming the type would be a breaking change which isn't worth the consequences. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Should be happy now. Had some whitespaces in the commits :^) |
Did we turn off branch protection? I have merge permission even though the PR isn't green yet |
I see it too, but didn't notice before 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM assuming happy tests |
I assume these are flakes (for the record):
|
I seem to be unable to restart the flaked test. Maybe someone else can try? |
Seems like an UI issue here. Jobs are running but the UI isn't updating. @cevich is investigating. |
/lgtm |
I wanted to enable golangci-lint for the
test/
directory (which is currently not checked) and noticed that new errors were introduced to the rest of the code. I have no idea how that was possible but now the linter is happy again.@giuseppe @mheon @baude @TomSweeneyRedHat @rhatdan PTAL