New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove c.String(net) #4869
Remove c.String(net) #4869
Conversation
Lots of tests are still using --net, so we have good test coverage. |
cmd/podman/common.go
Outdated
return pflag.NormalizedName(name) | ||
} | ||
|
||
createFlags.SetNormalizeFunc(aliasNet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we already have a version of this in create.go/run.go - can they be combined?
Is it just me? I cannot see the cirrus jobs at the moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge branch 'master' of github.com:containers/libpod into network
This commit looks like rebasing went wrong?
cmd/podman/utils.go
Outdated
@@ -61,7 +61,11 @@ func aliasFlags(f *pflag.FlagSet, name string) pflag.NormalizedName { | |||
name = "health-start-period" | |||
case "healthcheck-timeout": | |||
name = "health-timeout" | |||
case "net": | |||
name = "network" | |||
break |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The break looks redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cevich I think cirrus is sick? |
You need to rebase. I killed gating (see email) |
We have a lot of cludgy code trying to make --net and --network equivalent. This will allow --net to still exists but will eliminate the help and confusion. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
/lgtm |
We have a lot of cludgy code trying to make --net and --network equivalent.
This will allow --net to still exists but will eliminate the help and confusion.
Signed-off-by: Daniel J Walsh dwalsh@redhat.com