Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for target property when building images #140

Merged
merged 1 commit into from Apr 22, 2020

Conversation

fisxoj
Copy link
Contributor

@fisxoj fisxoj commented Apr 7, 2020

Enables this feature: https://docs.docker.com/compose/compose-file/#target

For multi-stage builds, this allows picking a stage to build up to a certain stage in the given Dockerfile.

Podman already seems to support this, so it was as easy as passing through the value, if it exists.

This version worked for me, but I don't know the complexities of handling the other arguments or what would be a good way to test this. Definitely open to feedback, I'm just limited on time, so it may take me a while to get back to it.

Thanks for your hard work on podman-compose so far!

For multi-stage builds, this allows picking a stage to build up to
@muayyad-alsadi muayyad-alsadi merged commit f9915c4 into containers:devel Apr 22, 2020
@fisxoj fisxoj deleted the feature/build-targets branch Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants