From b3b5512335b718cce8856998a511888ab3b3bfd6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Anders=20F=20Bj=C3=B6rklund?= <anders.f.bjorklund@gmail.com>
Date: Sun, 3 Dec 2023 16:15:06 +0100
Subject: [PATCH] feat: show container connection type and endpoint
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Make the container and the kubernetes endpoint look more similar.

Show the connection type, since it might not match the provider.

Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
---
 .../PreferencesContainerConnectionDetailsSummary.svelte  | 7 ++++++-
 .../PreferencesKubernetesConnectionDetailsSummary.svelte | 4 ++++
 .../lib/preferences/PreferencesResourcesRendering.svelte | 9 +++++++++
 3 files changed, 19 insertions(+), 1 deletion(-)

diff --git a/packages/renderer/src/lib/preferences/PreferencesContainerConnectionDetailsSummary.svelte b/packages/renderer/src/lib/preferences/PreferencesContainerConnectionDetailsSummary.svelte
index 4d31ec915a587..b230ed6c6535f 100644
--- a/packages/renderer/src/lib/preferences/PreferencesContainerConnectionDetailsSummary.svelte
+++ b/packages/renderer/src/lib/preferences/PreferencesContainerConnectionDetailsSummary.svelte
@@ -62,10 +62,15 @@ $: providerContainerConfiguration = tmpProviderContainerConfiguration.filter(
           {/if}
         </div>
       {/each}
+      <div class="flex flex-row mt-5">
+        <span class="font-semibold min-w-[150px]">Type</span>
+        <span aria-label="{containerConnectionInfo.type}"
+          >{#if containerConnectionInfo.type === 'docker'}Docker{:else if containerConnectionInfo.type === 'podman'}Podman{/if}</span>
+      </div>
       <div class="flex flex-row mt-5">
         <span class="font-semibold min-w-[150px]">Endpoint</span>
         <span aria-label="{containerConnectionInfo.endpoint.socketPath}"
-          >{containerConnectionInfo.endpoint.socketPath}</span>
+          >unix://{containerConnectionInfo.endpoint.socketPath}</span>
       </div>
     </div>
   {/if}
diff --git a/packages/renderer/src/lib/preferences/PreferencesKubernetesConnectionDetailsSummary.svelte b/packages/renderer/src/lib/preferences/PreferencesKubernetesConnectionDetailsSummary.svelte
index dc379aa1134ae..dbec0905b85bd 100644
--- a/packages/renderer/src/lib/preferences/PreferencesKubernetesConnectionDetailsSummary.svelte
+++ b/packages/renderer/src/lib/preferences/PreferencesKubernetesConnectionDetailsSummary.svelte
@@ -43,6 +43,10 @@ $: providerConnectionConfiguration = tmpProviderContainerConfiguration.filter(
           <span>{connectionSetting.value}</span>
         </div>
       {/each}
+      <div class="flex flex-row mt-5">
+        <span class="font-semibold min-w-[150px]">Type</span>
+        <span aria-label="kubernetes">Kubernetes</span>
+      </div>
       <div class="flex flex-row mt-5">
         <span class="font-semibold min-w-[150px]">Endpoint</span>
         <span aria-label="{kubernetesConnectionInfo.endpoint.apiURL}">{kubernetesConnectionInfo.endpoint.apiURL}</span>
diff --git a/packages/renderer/src/lib/preferences/PreferencesResourcesRendering.svelte b/packages/renderer/src/lib/preferences/PreferencesResourcesRendering.svelte
index a970766ebc63e..612de285a89ac 100644
--- a/packages/renderer/src/lib/preferences/PreferencesResourcesRendering.svelte
+++ b/packages/renderer/src/lib/preferences/PreferencesResourcesRendering.svelte
@@ -473,6 +473,15 @@ function hasAnyConfiguration(provider: ProviderInfo) {
                   <ConnectionErrorInfoButton status="{status}" />
                 {/if}
               </div>
+              <div class="mt-2">
+                <div class="text-gray-700 text-xs">
+                  {#if container.type === 'docker'}Docker{:else if container.type === 'podman'}Podman{/if} endpoint
+                </div>
+                <div class="mt-1">
+                  <span class="my-auto text-xs" class:text-gray-900="{container.status !== 'started'}"
+                    >unix://{container.endpoint.socketPath}</span>
+                </div>
+              </div>
 
               {#if providerContainerConfiguration.has(provider.internalId)}
                 {@const providerConfiguration = providerContainerConfiguration.get(provider.internalId) || []}