Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show rootfull and allow setting it on restart? #2612

Open
maxandersen opened this issue May 24, 2023 · 2 comments
Open

show rootfull and allow setting it on restart? #2612

maxandersen opened this issue May 24, 2023 · 2 comments
Labels
area/extension/podman 🦭 kind/enhancement ✨ Issue for requesting an improvement

Comments

@maxandersen
Copy link

Is your enhancement related to a problem? Please describe

with #2427 I can now create new machines with rootful - nice.

But in resources you can't see if it is on or off:

2023-05-24_08-34-55

and when clicking restart no option to turn on/off. For this I'm forced to go to the terminal.

Describe the solution you'd like

show the rootfull or not mode in the overview.

on restart have option to tweak the parameters that are changeable between restarts (i.e. rootfull)

Describe alternatives you've considered

No response

Additional context

No response

@maxandersen maxandersen added the kind/enhancement ✨ Issue for requesting an improvement label May 24, 2023
@benoitf
Copy link
Collaborator

benoitf commented May 24, 2023

It depends on containers/podman#18479

@afbjorklund
Copy link
Contributor

afbjorklund commented May 24, 2023

I had similar issues when connecting to the local socket, since the location was hardcoded.

--- a/extensions/podman/src/extension.ts
+++ b/extensions/podman/src/extension.ts
@@ -270,7 +270,7 @@ function getLinuxSocketPath(): string {
   const userInfo = os.userInfo();
   const uid = userInfo.uid;
 
-  return `/run/user/${uid}/podman/podman.sock`;
+  return '/run/podman/podman.sock';
 }
 
 // on linux, socket is started by the system service on a path like /run/user/1000/podman/podman.sock

It could use this rootful boolean as well, to pick the socket. Same goes for the docker socket.

--- a/extensions/docker/src/extension.ts
+++ b/extensions/docker/src/extension.ts
@@ -147,7 +147,11 @@ export async function activate(extensionContext: extensionApi.ExtensionContext):
   if (isWindows) {
     socketPath = '//./pipe/docker_engine';
   } else {
-    socketPath = '/var/run/docker.sock';
+    // grab user id of the user
+    const userInfo = os.userInfo();
+    const uid = userInfo.uid;
+
+    socketPath = `/run/user/${uid}/docker.sock`;
   }
 
   // monitor daemon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/extension/podman 🦭 kind/enhancement ✨ Issue for requesting an improvement
Projects
Status: 📋 Backlog
Development

No branches or pull requests

4 participants