-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tip slot to customize tip content #7150
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if we should not use a so we could put whatever we want without being limited to text
I assume you meant 'slot'. If so, +1. We may want more interesting tooltips in the future (e.g. include image or link) so slot would give more flexibility. |
Not sure to get it. Do you want something like?
|
77b1330
to
15b3b03
Compare
Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
Signed-off-by: lstocchi <lstocchi@redhat.com>
packages/renderer/src/lib/deployments/DeploymentColumnConditions.svelte
Outdated
Show resolved
Hide resolved
Signed-off-by: lstocchi <lstocchi@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for taking the time to make the change! 🚀
* feat: allow to add custom classes to tip Signed-off-by: lstocchi <lstocchi@redhat.com> * fix: add tip slot into tooltip Signed-off-by: lstocchi <lstocchi@redhat.com> * fix: add check for tip content Signed-off-by: lstocchi <lstocchi@redhat.com> * fix: rename slot as per review Signed-off-by: lstocchi <lstocchi@redhat.com> --------- Signed-off-by: lstocchi <lstocchi@redhat.com>
What does this PR do?
This PR adds a tip slot so that one can customize the tip content.
In AI Lab we can use it to show the content multiline instead of a single line
Screenshot / video of UI
An example is the output i want to have in AI Lab.
What issues does this PR fix or reference?
N/A
How to test this PR?
run tests