Refactor podman pods to report.Formatter #12490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jwhonce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
jwhonce
force-pushed
the
issues/10974-3
branch
from
d42d607
to
cb0023e
Compare
|
LGTM |
jwhonce
force-pushed
the
issues/10974-3
branch
2 times, most recently
from
85e3c1a
to
b9ab4fa
Compare
jwhonce
force-pushed
the
issues/10974-3
branch
from
b9ab4fa
to
73e6b11
Compare
|
LGTM once tests go green |
[NO NEW TESTS NEEDED] Support better compatibility output for podman pods commands See containers#10974 Depends on containers/common#831 Signed-off-by: Jhon Honce <jhonce@redhat.com>
jwhonce
force-pushed
the
issues/10974-3
branch
from
73e6b11
to
d35aa3f
Compare
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[NO NEW TESTS NEEDED]
Support better compatibility output for podman system commands
See #10974
Depends on containers/common#831
Signed-off-by: Jhon Honce jhonce@redhat.com
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer: