Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4reverts #13392

Merged
merged 2 commits into from Mar 1, 2022
Merged

V4reverts #13392

merged 2 commits into from Mar 1, 2022

Conversation

baude
Copy link
Member

@baude baude commented Mar 1, 2022

Reverting two previous commits as one causes an error and one was not published.

This reverts commit ca980c2.

Signed-off-by: Brent Baude <bbaude@redhat.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2022
@rhatdan
Copy link
Member

rhatdan commented Mar 1, 2022

/approve
/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TomSweeneyRedHat
Copy link
Member

LGTM

This reverts commit fc5cf81.

[NO NEW TESTS NEEDED]

Signed-off-by: Brent Baude <bbaude@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2022
@rhatdan
Copy link
Member

rhatdan commented Mar 1, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2022
@edsantiago edsantiago added 4.0 do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Mar 1, 2022
@baude
Copy link
Member Author

baude commented Mar 1, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2022
@openshift-merge-robot openshift-merge-robot merged commit 965d280 into containers:v4.0 Mar 1, 2022
@TomSweeneyRedHat
Copy link
Member

TomSweeneyRedHat commented Mar 1, 2022

UGH, this should not have been merged until we get approval from RHEL. Please do NOT merge anything into this branch with our first verifying with me.

@lsm5
Copy link
Member

lsm5 commented Mar 2, 2022

/cc @jnovy

@openshift-ci openshift-ci bot requested a review from jnovy March 2, 2022 01:29
@baude
Copy link
Member Author

baude commented Mar 2, 2022

either way these commits needed to happen. whether it is 4.0.2 now or something else later.

@baude baude deleted the v4reverts branch May 18, 2022 15:17
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants