Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quadlet: exit 0 when there are no files to process #17398

Merged
merged 1 commit into from Feb 7, 2023

Conversation

vrothberg
Copy link
Member

Quadlet should not exit with failure if no files to process have been found. Otherwise, even simple operations such as reloading systemd will fail as it retriggers generators.

Fixes: #17374
Signed-off-by: Valentin Rothberg vrothberg@redhat.com

Does this PR introduce a user-facing change?

None

Quadlet should not exit with failure if no files to process have been
found.  Otherwise, even simple operations such as reloading systemd
will fail as it retriggers generators.

Fixes: containers#17374
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2023
@vrothberg
Copy link
Member Author

/cherry-pick v4.4

@ygalblum @alexlarsson @rhatdan PTAL

@openshift-cherrypick-robot
Copy link
Collaborator

@vrothberg: once the present PR merges, I will cherry-pick it on top of v4.4 in a new PR and assign it to you.

In response to this:

/cherry-pick v4.4

@ygalblum @alexlarsson @rhatdan PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ygalblum
Copy link
Collaborator

ygalblum commented Feb 7, 2023

LGTM (but I can't add the label myself)

@rhatdan
Copy link
Member

rhatdan commented Feb 7, 2023

/lgtm
/cherry-pick v4.4

@openshift-cherrypick-robot
Copy link
Collaborator

@rhatdan: once the present PR merges, I will cherry-pick it on top of v4.4 in a new PR and assign it to you.

In response to this:

/lgtm
/cherry-pick v4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2023
@openshift-merge-robot openshift-merge-robot merged commit a8b28f4 into containers:main Feb 7, 2023
56 checks passed
@openshift-cherrypick-robot
Copy link
Collaborator

@rhatdan: new pull request created: #17410

In response to this:

/lgtm
/cherry-pick v4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrothberg vrothberg deleted the fix-17374 branch February 7, 2023 16:07
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: podman-system-generator failed with exit status 1
6 participants