Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.4.1-rhel] Add new bclim macvlan option #18695

Merged
merged 2 commits into from May 29, 2023

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented May 26, 2023

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2023
@Luap99
Copy link
Member Author

Luap99 commented May 26, 2023

/hold wait for final ack from @TomSweeneyRedHat

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2023
@TomSweeneyRedHat
Copy link
Member

LGTM, but the aarch64 root host test is failing, I've restarted

@rhatdan
Copy link
Member

rhatdan commented May 29, 2023

/lgtm
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 29, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2023
@openshift-merge-robot openshift-merge-robot merged commit bcea446 into containers:v4.4.1-rhel May 29, 2023
54 checks passed
@Luap99 Luap99 deleted the v4.4.1-rhel branch May 30, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants