New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate make helping message dynamicaly. #2283
Conversation
/assign @rhatdan |
Can one of the admins verify this patch?
|
@4383: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
bot, add author to whitelist |
/approve |
Makefile
Outdated
@@ -164,10 +172,10 @@ integration.fedora: | |||
integration.centos: | |||
DIST=CentOS sh .papr_prepare.sh | |||
|
|||
shell: libpodimage | |||
shell: libpodimage ## Run the builted image and attach a shell |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/buillted/built/
Makefile
Outdated
${CONTAINER_RUNTIME} run -e STORAGE_OPTIONS="--storage-driver=vfs" -e CGROUP_MANAGER=cgroupfs -e TESTFLAGS -e OCI_RUNTIME -e TRAVIS -it --privileged --rm -v ${CURDIR}:/go/src/${PROJECT} ${LIBPOD_IMAGE} sh | ||
|
||
testunit: libpodimage | ||
testunit: libpodimage ## Run unittest on the builted image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/builted/built/
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 4383, TomSweeneyRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Makefile
Outdated
${CONTAINER_RUNTIME} build -t ${LIBPOD_IMAGE} . | ||
|
||
dbuild: libpodimage | ||
${CONTAINER_RUNTIME} run --name=${LIBPOD_INSTANCE} --privileged -v ${PWD}:/go/src/${PROJECT} --rm ${LIBPOD_IMAGE} make all | ||
|
||
test: libpodimage | ||
test: libpodimage ## Run tests on builted image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/builted/built/
@4383 thanks for the PR. I like the look/feel of this, thanks for posting the PR. I found a few nits that I commented on. The python dependency I'm a little cautious on, but good to hear it works with python 2 or 3. I think adding a python dependency is OK, but I'll let others weigh in on that. |
Generate make helping message dynamicaly by using python code snippet inside Makefile. All commented make targets will be added to the help message. To be added to the helping message comment need to start with '## '. These specials comments are detected by the python code. Python code generate the helping output from these results. Notice that this commit introduce a dependency with python (compatible python 2 and 3). Signed-off-by: Hervé Beraud <hberaud@redhat.com>
f6f5d8b
to
e0c3af6
Compare
@TomSweeneyRedHat nits fixed! :) |
@4383: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
LGTM, assuming happy tests and the Python dependency being hip with others. |
/lgtm |
Summarize
Generate make helping message dynamicaly by using
python code snippet inside Makefile.
All commented make targets will be added to the
help message. To be added to the helping message
comment need to start with '## '.
These specials comments are detected by the python code.
Python code generate the helping output from these results.
Notice that this commit introduce a dependency with python (compatible python 2 and 3).
Signed-off-by: Hervé Beraud hberaud@redhat.com
Sample output
My changes generate the following outputs:
You can test them by using the following commands:
Warning
Cheers!