[v4.4.1-rhel] Ensure that containers do not get stuck in stopping #23089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scenario for inducing this is as follows: 1. Start a container with a long stop timeout and a PID1 that ignores SIGTERM 2. Use `podman stop` to stop that container 3. Simultaneously, in another terminal, kill -9 `pidof podman` (the container is now in ContainerStateStopping) 4. Now kill that container's Conmon with SIGKILL. 5. No commands are able to move the container from Stopping to Stopped now. The cause is a logic bug in our exit-file handling logic. Conmon being dead without an exit file causes no change to the state. Add handling for this case that tries to clean up, including stopping the container if it still seems to be running. Fixes containers#19629 Addresses: https://issues.redhat.com/browse/ACCELFIX-250 Signed-off-by: Matt Heon <mheon@redhat.com> Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
TomSweeneyRedHat
added
do-not-merge/hold
openshift-ci
bot
added
do-not-merge/work-in-progress
TomSweeneyRedHat
removed
the
do-not-merge/hold
|
Ready for review and happy green tests buttons. Ditto #23088 |
TomSweeneyRedHat
removed
do-not-merge/work-in-progress
TomSweeneyRedHat
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, TomSweeneyRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 38ccfa2
into
containers:v4.4.1-rhel
52 checks passed
|
Addresses: https://issues.redhat.com/browse/RHEL-45530 |
stale-locking-app
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scenario for inducing this is as follows:
podman stopto stop that containerpidof podman(the container is now in ContainerStateStopping)The cause is a logic bug in our exit-file handling logic. Conmon being dead without an exit file causes no change to the state. Add handling for this case that tries to clean up, including stopping the container if it still seems to be running.
Fixes #19629
Addresses: https://issues.redhat.com/browse/ACCELFIX-250
Does this PR introduce a user-facing change?