-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI:BUILD] Minor: Rename the OSX Cross task #23105
Conversation
LGTM |
Re-drafting: There's a bug in the artifacts task. |
f05ae7d
to
808d6c0
Compare
Fixed, now the artifacts task is working with the updated OSX task name. |
For a long time, this task has not been cross-compiling, it's building natively on a Mac. Avoid any possible confusion by renaming the task. Signed-off-by: Chris Evich <cevich@redhat.com>
Force-push: Renamed to "Build for MacOS amd64+arm64" |
Ephemeral COPR build failed. @containers/packit-build please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
eff706a
into
containers:main
I was about to comment yesterday that the implicit name -> URL dependency sucks as this is totally non obvious but didn't spend time actually checking for other places. Turns out it is used in more than one place... I already pushed a commit to fix it in my machine PR: da2cbb0 |
Oof, yeah, this is really horrible. Sorry for assuming that the "artifacts" task was the only place 😞 The only way I can think to "fix" this, is to add a comment on every relevant |
For many months this task has not been cross-compiling, it's building natively on a Mac. Avoid any possible confusion by renaming the task.
Does this PR introduce a user-facing change?