Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:BUILD] Minor: Rename the OSX Cross task #23105

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

cevich
Copy link
Member

@cevich cevich commented Jun 25, 2024

For many months this task has not been cross-compiling, it's building natively on a Mac. Avoid any possible confusion by renaming the task.

Does this PR introduce a user-facing change?

None

@cevich cevich changed the title [CI:DOCS] Minor: Rename the OSX Cross task [CI:BUILD] Minor: Rename the OSX Cross task Jun 25, 2024
@rhatdan
Copy link
Member

rhatdan commented Jun 25, 2024

LGTM

@cevich cevich marked this pull request as draft June 25, 2024 18:08
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2024
@cevich
Copy link
Member Author

cevich commented Jun 25, 2024

Re-drafting: There's a bug in the artifacts task.

@cevich cevich force-pushed the rename_osx_cross branch 2 times, most recently from f05ae7d to 808d6c0 Compare June 25, 2024 19:00
@cevich
Copy link
Member Author

cevich commented Jun 25, 2024

Fixed, now the artifacts task is working with the updated OSX task name.

@cevich cevich marked this pull request as ready for review June 25, 2024 19:31
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2024
.cirrus.yml Outdated Show resolved Hide resolved
For a long time, this task has not been cross-compiling, it's building
natively on a Mac.  Avoid any possible confusion by renaming the task.

Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich
Copy link
Member Author

cevich commented Jun 26, 2024

Force-push: Renamed to "Build for MacOS amd64+arm64"

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@cevich cevich requested review from Luap99 and ashley-cui June 26, 2024 17:16
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2024
Copy link
Contributor

openshift-ci bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit eff706a into containers:main Jun 26, 2024
40 of 42 checks passed
@Luap99
Copy link
Member

Luap99 commented Jun 27, 2024

I was about to comment yesterday that the implicit name -> URL dependency sucks as this is totally non obvious but didn't spend time actually checking for other places. Turns out it is used in more than one place...
https://cirrus-ci.com/task/6562960993157120. This PR really should have not used CI:BUILD.

I already pushed a commit to fix it in my machine PR: da2cbb0

@cevich
Copy link
Member Author

cevich commented Jun 27, 2024

implicit name -> URL dependency

Oof, yeah, this is really horrible. Sorry for assuming that the "artifacts" task was the only place 😞

The only way I can think to "fix" this, is to add a comment on every relevant name: line warning humans to go searching for the URL-encoded lines. I'm not very happy about needing to do that though, so if you can think of a better solution (starlark?), PLMK.

@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants