-
Notifications
You must be signed in to change notification settings - Fork 2.9k
[docs] Refactor Artifact API documentation #26854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Refactor Artifact API documentation #26854
Conversation
pkg/api/server/register_artifacts.go
Outdated
| // - name: fileName | ||
| // in: query | ||
| // description: File to be added to the artifact | ||
| // description: Name of the file to be added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it name or path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks, it should certainly be path!
|
LGTM |
Add artifact tag to tags.yaml so API docs are ordered correctly (alphabetically with libpod endpoints first). Refactor artifact API documentation to be consistently formated. Refactor some descriptions and summaries to be more accurate and user friendly. Signed-off-by: Lewis Roy <lewis@redhat.com>
bb65f1e to
be0ad4a
Compare
Luap99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, ninja-quokka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
aa006d1
into
containers:main
Add artifact tag to tags.yaml so API docs are ordered correctly (alphabetically with libpod endpoints first).
Refactor artifact API documentation to be consistently formated.
Refactor some descriptions and summaries to be more accurate and user friendly.
Does this PR introduce a user-facing change?