Skip to content

Conversation

@ninja-quokka
Copy link
Collaborator

Add artifact tag to tags.yaml so API docs are ordered correctly (alphabetically with libpod endpoints first).

Refactor artifact API documentation to be consistently formated.

Refactor some descriptions and summaries to be more accurate and user friendly.

Does this PR introduce a user-facing change?

None

@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label Aug 18, 2025
@ninja-quokka ninja-quokka added the No New Tests Allow PR to proceed without adding regression tests label Aug 18, 2025
// - name: fileName
// in: query
// description: File to be added to the artifact
// description: Name of the file to be added
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it name or path

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks, it should certainly be path!

@TomSweeneyRedHat
Copy link
Member

LGTM
once tests are happy and @baude 's question is resolved.

Add artifact tag to tags.yaml so API docs are ordered correctly
(alphabetically with libpod endpoints first).

Refactor artifact API documentation to be consistently formated.

Refactor some descriptions and summaries to be more accurate and user
friendly.

Signed-off-by: Lewis Roy <lewis@redhat.com>
@ninja-quokka ninja-quokka force-pushed the format_artifact_api_doc branch from bb65f1e to be0ad4a Compare August 19, 2025 00:23
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, ninja-quokka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit aa006d1 into containers:main Aug 19, 2025
78 of 81 checks passed
@ninja-quokka ninja-quokka deleted the format_artifact_api_doc branch August 19, 2025 14:23
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Nov 18, 2025
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Nov 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Change to remote API; merits scrutiny lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. No New Tests Allow PR to proceed without adding regression tests release-note-none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants