fix search output limit #3693
fix search output limit #3693
Conversation
| search = podmanTest.Podman([]string{"search", "--limit", "30", "docker.io/alpine"}) | ||
| search.WaitWithDefaultTimeout() | ||
| Expect(search.ExitCode()).To(Equal(0)) | ||
| Expect(len(search.OutputToStringArray())).To(Equal(31)) |
There was a problem hiding this comment.
Could you add a test to verify that without --limit you get 25 lines returned? Or is that in play already?
There was a problem hiding this comment.
fixed. Add another search under --limit section to check the number of lines.
close https://bugzilla.redhat.com/show_bug.cgi?id=1732280 From the bug Podman search returns 25 results even when limit option `--limit` is larger than 25(maxQueries). They want Podman to return `--limit` results. This PR fixes the number of output result. if --limit not set, return MIN(maxQueries, len(res)) if --limit is set, return MIN(option, len(res)) Signed-off-by: Qi Wang <qiwan@redhat.com>
|
LGTM assuming happy tests. |
|
Sorry, didn't mean to close, hit the wrong button. |
if golang has math.Max() or Min() for integer, the code will look simple |
|
I like it when these things end up being simple fixes. |
|
LGTM |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon, QiWang19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
close https://bugzilla.redhat.com/show_bug.cgi?id=1732280
From the bug Podman search returns 25 results even when limit option
--limitis larger than 25(maxQueries). They want Podman to return--limitresults.This PR fixes the number of output result.
if --limit not set, return MIN(maxQueries, len(res))
if --limit is set, return MIN(option, len(res))
Signed-off-by: Qi Wang qiwan@redhat.com