-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Cleanup transfer.md page, remove CRI-O content #883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
transfer.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a backtick after podman
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
transfer.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe runtime daemon instead of container daemon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd pref "Podman" through out with the exception of commands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
This page has not been updated since we copied it from CRI-O repo. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
TomSweeneyRedHat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and happy green test buttons.
Thanks for the PODMAN to Podman changes.
|
LGTM |
|
📌 Commit 2e17fd8 has been approved by |
|
⚡ Test exempted: pull fully rebased and already tested. |
This page has not been updated since we copied it from CRI-O repo.
Signed-off-by: Daniel J Walsh dwalsh@redhat.com