Call recreateSymlinks when not found during Readlink #822
Conversation
If the symlinks under the l directory are lost during a sudden reboot, we can hit an error when grabbing the lower directories and reading the symlinks before they are recreated in the Get function. Add a call to recreateSymlinks in this code path as well. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
|
LGTM |
|
Should we at least warn that the storage is corrupted and files might be missing or are partially stored? |
|
@giuseppe there is a warning that we can't find the symlinks so going to restore those https://github.com/containers/storage/pull/822/files#diff-4b0197157e354c66e154f5cdc6fea71c4e43732b4bad32d8652f23bd588e51a1R819 |
I am just worried that users will get the impression this would fix the storage corruptions but there could be other issues that we are not able to detect yet, such as missing or incomplete files in the pulled images. Maybe a warning saying the safest is probably to completely wipe the storage if possible to not incur in weird errors? |
|
SGTM |
|
Follow up with warning in #833 |
If the symlinks under the l directory are lost during a
sudden reboot, we can hit an error when grabbing the lower
directories and reading the symlinks before they are recreated
in the Get function. Add a call to recreateSymlinks in this
code path as well.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1921128
Signed-off-by: Urvashi Mohnani umohnani@redhat.com