-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First attempt at an Ubuntu toolbox container image. #298
Conversation
This isn't as clean as the fedora/centos variants. There's also a problem on first run where toolbox emits 'toolbox: failed to create /run/.toolboxenv in container' but runs normally from there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this! It looks very good. Some comments below:
version="$VERSION" \ | ||
usage="This image is meant to be used with the toolbox command" \ | ||
summary="Base image for creating Ubuntu 19.04 toolbox containers" \ | ||
maintainer="Debarshi Ray <rishi@fedoraproject.org>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I convince you to be the maintainer of these Ubuntu images? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not, I only use Centos and Fedora. Debian and its derivatives aren't anything I work with normally. I really just did this one as a demonstration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.
Before we announce support for Ubuntu, we would need somebody who cares enough about Ubuntu to ensure that Toolbox keeps working on a day to day basis with Ubuntu hosts and images. I am a little apprehensive of taking up that responsibility myself. I could, but it seems wise to spread the load around a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, in the meantime, we can work towards removing the rough edges before thinking of making any announcements. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me.
I just spent about an hour putting together a Ubuntu toolbox container (using I do have an issue with sudo complaining about not being able to resolve the |
About /etc/hosts https://github.com/containers/toolbox/blob/master/toolbox#L1079 it's supposed to get indirected. Maybe check if it's already a symlink in the image? |
@@ -0,0 +1,17 @@ | |||
bash-completion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am curious. Did you check that these packages are the ones missing from the Ubuntu base image that are necessary to replicate the command line user experience on a usual Ubuntu host?
To be honest, I am not sure what's the most future-proof option here. We started off by trying to replicate the default Fedora Workstation/Silverblue CLI UX in the Toolbox images. However, now that we are adding other distributions, and supporting different variants of Fedora other than Silverblue and Workstation, I don't know what a freshly created container should have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's part of the reason I don't want to maintain the Ubuntu toolbox image. I don't actually use the distribution, so I can't say what a "usual" user experience would be for it.
It's being properly indirected inside the container, but |
Having a Ubuntu container could help driving conversions from Ubuntu users. It looks like this has been pending a review since early November. Supporting a Ubuntu LTS container would be great too. |
I tested this image as follows:
Unfortunately, the container exits immediately with an return value of 127. According to Here's the final output of running the
|
@markstos: Looking into your concern. I can't get toolbox to create a container from the image number:
Once I tag that image, I can create the toolbox container:
The container then "works for me:"
|
@kronenpj I got the image ID from the output of |
@markstos Yes, I did leave that step out. I think it was actually |
For anyone who wants to use ubuntu containers with toolbox now: I have a script that can build a debian or ubuntu container for any release from the stock dockerhub images. |
@martinpitt Thanks. I see a comment in there about systemd. Does systemd work inside these containers? I also see that |
@markstos : systemd is not really being used in the containers. It's just commonly getting installed as a build dependency, and /var/log/journal/ being a bind mount to the real system confuses the package postinst script, so the package fails to install. I forgot about the particular reason for libwww-perl, I think a tool like dget or dput needs it. I reduced dependencies with |
@martinpitt When I use your script to try to make an ubuntu container, I get the following error:
|
@mjlbach : Indeed I get the same now, on any Debian/Ubuntu release. That smells like a recent podman regression, I'll look into it this evening. |
What's the current status of this? |
I'm grateful everyone's work on this thus far. I know that Ubuntu might not be Redhat / Fedora folk's primary target here, but any update would be appreciated. |
looking for the same |
I'm also interested in running Ubuntu in a container on fedora silverblue, any update on this? |
I'm not sure that use case will actually work until this project sorts out glibc compatibility issues |
Please try images from #483 PR - they should be more complete and few recent LTS releases are available. |
Hey @kronenpj did you receive my email to your |
My apologies. I just remembered that you had already mentioned on this pull request that you don't want to maintain the Ubuntu support because you don't actually use it and you only did it as a demo. I have marked those conversation threads as unresolved so that they don't get hidden in the noise. |
I am closing this pull request since @kronenpj doesn't want to maintain the Ubuntu support long-term, and we can't merge stuff that has nobody maintaining it. |
Let's focus on #483 which is more active. :) |
This isn't as clean as the fedora/centos variants. There's also a problem on first run where toolbox
emits 'toolbox: failed to create /run/.toolboxenv in container' but runs normally from there.