Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm install fail due to Template.metadata.labels #305

Closed
valentin2105 opened this issue Oct 24, 2019 · 2 comments · Fixed by #310
Milestone

Comments

@valentin2105
Copy link

@valentin2105 valentin2105 commented Oct 24, 2019

Hi,

I would like to try Maesh in my single Node Kubernetes cluster (1.16.1),

When I helm install it, I got this error,

$ helm install --name=maesh --namespace=maesh maesh/maesh

Error: release maesh failed: Deployment.apps "grafana-core" is invalid: [spec.selector: Required value, spec.template.metadata.labels: Invalid value: map[string]string{"app":"grafana", "component":"core"}: `selector` does not match template `labels`]

If I disable monitoring, I got the same issue with Open Tracing.

Any idea how to fix this ? I try to fix the yaml but unsuccessfully

@riker09

This comment has been minimized.

Copy link

@riker09 riker09 commented Oct 25, 2019

I'm having the same issue, I believe. I'm trying to deploy with tracing disabled:

$ helm install --name=maesh --namespace=maesh --set tracing.deploy=false --set tracing.jaeger.enabled=false maesh/maesh
Error: release maesh failed: Deployment.apps "prometheus-core" is invalid: [spec.selector: Required value, spec.template.metadata.labels: Invalid value: map[string]string{"app":"prometheus", "component":"core"}: `selector` does not match template `labels`]

I think it has something to do with the involved software and versions. I'm using k3s version 0.10.0 (f9888ca3). kubectl version gives

Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.2", GitCommit:"c97fe5036ef3df2967d086711e6c0c405941e14b", GitTreeState:"clean", BuildDate:"2019-10-15T19:18:23Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.2-k3s.1", GitCommit:"b8b17ba55f20e590df507fce333dfee13ab438c6", GitTreeState:"clean", BuildDate:"2019-10-16T05:17Z", GoVersion:"go1.13.3", Compiler:"gc", Platform:"linux/amd64"}

And lastly helm version:

Client: &version.Version{SemVer:"v2.15.1", GitCommit:"cf1de4f8ba70eded310918a8af3a96bfe8e7683b", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.15.1", GitCommit:"cf1de4f8ba70eded310918a8af3a96bfe8e7683b", GitTreeState:"clean"}

I have tried getting maesh installed on a minikube cluster. I had to use helm in version 2.14.3 to be able to deploy anything but ran into issues with the persistant volumes I wasn't able to fix. See #267

@brennerm

This comment has been minimized.

Copy link
Contributor

@brennerm brennerm commented Oct 27, 2019

With switching to the K8s API version apps/v1 (53c7323) the spec.selector field apparently became required for deployments. Will prepare a PR to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.