Feature/scheme service #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmatur
added
kind/enhancement
dtomcej
reviewed
Oct 9, 2019
| func (p *Provider) getScheme(annotations map[string]string) string { | ||
| scheme := annotations[k8s.AnnotationScheme] | ||
|
|
||
| if scheme == "" { |
There was a problem hiding this comment.
we should validate that the scheme is an acceptable scheme here.
| @@ -180,6 +181,16 @@ func (p *Provider) getServiceMode(annotations map[string]string) string { | |||
| return mode | |||
| } | |||
|
|
|||
| func (p *Provider) getScheme(annotations map[string]string) string { | |||
There was a problem hiding this comment.
since this doesn't actually use the provider at all, did we want to have this method moved to the base package so that we can use it with the SMI provider?
|
Did we want to add this functionality to the SMI provider in this PR? or did we want to add it in another? |
mmatur
force-pushed
the
feature/scheme-service
branch
from
9343679
to
4468ee0
Compare
mmatur
force-pushed
the
feature/scheme-service
branch
from
4468ee0
to
f91a898
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow user to customize scheme.