New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide easy way to test Traefik Provider against Service Fabric with Docker #21

Open
wants to merge 36 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@lawrencegripper
Copy link
Contributor

lawrencegripper commented Dec 22, 2017

This PR adds a simple way to start a cluster inside a docker image, with apps running, to test the behavior of the provider.

Related to #7

@ldez

This comment has been minimized.

Copy link
Member

ldez commented Dec 22, 2017

To be consistent with Træfik could you rename integrationtesting/ to integration/ ?

@ldez ldez added this to the traefik-v1.6 milestone Dec 22, 2017

@lawrencegripper lawrencegripper force-pushed the integration branch 2 times, most recently from 9650b38 to 2313df1 Dec 22, 2017

@lawrencegripper

This comment has been minimized.

Copy link
Contributor Author

lawrencegripper commented Dec 22, 2017

Done, I've added a note to the readme.md as you need to add the following to your docker daemon settings for the cluster to behave:

{
    "ipv6": true,
    "fixed-cidr-v6": "fd00::/64"
}

@lawrencegripper lawrencegripper requested a review from ldez Dec 22, 2017

@lawrencegripper

This comment has been minimized.

Copy link
Contributor Author

lawrencegripper commented Jan 4, 2018

@ldez I've been looking at the existing integration tests in the Traefik repo and could use some guidance.

Would you preference be for me to use github.com/libkermit/compose/check to start the SF docker image running the cluster then start the traefik binary?

My first thought was to write a test which starts the container then invoke the provide function on the sf provider and ensure the configuration returned was as expected. I'd also like to write a further test where labels are then altered using the SF API and validate the configuration change is picked up. Does this sound like a good plan?

To keep things simple I'm considering just using exec to invoke a bash script

@lawrencegripper lawrencegripper force-pushed the integration branch from 750f6ac to bb569f1 Jan 25, 2018

@lawrencegripper lawrencegripper force-pushed the integration branch from b890c31 to 28cb115 Jan 30, 2018

@lawrencegripper lawrencegripper force-pushed the integration branch 7 times, most recently from 8fe6f36 to 756a43e Jan 30, 2018

@ldez ldez removed this from the traefik-v1.6 milestone Mar 21, 2018

lawrencegripper added some commits Jul 2, 2018

@ldez ldez added the bot/no-merge label Jul 2, 2018

@lawrencegripper lawrencegripper force-pushed the integration branch 2 times, most recently from 69850a5 to a3ceb96 Jul 2, 2018

@lawrencegripper lawrencegripper force-pushed the integration branch from a3ceb96 to eb0ac4d Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment