Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds TCP support #4587

Merged
merged 3 commits into from Mar 14, 2019

Conversation

@juliens
Copy link
Member

commented Mar 14, 2019

What does this PR do?

Do we really need further explanations?

Motivation

Fix an old issue!

Fixes #10

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Yeah man!

Co-authored-by: Gérald Croës gerald@containo.us

juliens and others added some commits Mar 7, 2019

New protocol :)
Co-authored-by: Gérald Croës <gerald@containo.us>
Remove experimental feature
Co-authored-by: jbdoumenjou <jb.doumenjou@gmail.com>

@ldez ldez requested review from geraldcroes, ldez and jbdoumenjou Mar 14, 2019

@ldez

ldez approved these changes Mar 14, 2019

Copy link
Member

left a comment

LGTM

@SantoDE
Copy link
Contributor

left a comment

LGTM YOU BEAST! 👼

@jbdoumenjou
Copy link
Contributor

left a comment

LGTM 🚀

@traefiker traefiker merged commit 4a68d29 into containous:master Mar 14, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
semaphoreci The build passed on Semaphore.
Details
@lexicoder

This comment has been minimized.

Copy link

commented Mar 14, 2019

Awesome!!!

@gaui

This comment has been minimized.

Copy link

commented Mar 14, 2019

Wow awesome!

@kiwi-dejero

This comment has been minimized.

Copy link

commented Mar 15, 2019

Oh Boy Oh Boy Oh Boy !!

@ldez ldez changed the title Add a new protocol Add TCP support Mar 18, 2019

@ldez ldez changed the title Add TCP support Adds TCP support Mar 18, 2019

@ldez ldez added area/tcp and removed area/server labels Mar 18, 2019

@mariufa

This comment was marked as off-topic.

Copy link

commented Apr 3, 2019

Has anyone got this to work with postgres for instance?

@llitfkitfk

This comment has been minimized.

Copy link

commented Apr 16, 2019

Great!!!

@benyanke

This comment has been minimized.

Copy link

commented May 17, 2019

AWESOME.

@shantanugadgil

This comment has been minimized.

Copy link

commented Jul 2, 2019

This is genuinely awesome work!!!! Great job!!! 🥇 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.