New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move code to pkg #4596
Merged
Merged
Move code to pkg #4596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
kind/enhancement
a new or improved feature.
status/2-needs-review
area/infrastructure
labels
Mar 14, 2019
traefiker
added
area/acme
area/authentication
area/logs
area/middleware
area/provider/boltdb
area/provider/consul
area/provider/consulcatalog
area/provider/docker
area/provider/etcd
area/provider/ecs
area/provider/eureka
area/provider/k8s/ingress
area/provider/marathon
area/provider/mesos
area/provider/rancher
size/L
labels
Mar 14, 2019
ldez
added
area/infrastructure
and removed
area/provider/boltdb
area/provider/consul
area/provider/consulcatalog
area/provider/docker
area/provider/ecs
area/provider/etcd
area/provider/eureka
area/provider/k8s/ingress
area/provider/marathon
area/provider/mesos
area/provider/rancher
labels
Mar 14, 2019
juliens
approved these changes
Mar 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jbdoumenjou
approved these changes
Mar 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
geraldcroes
approved these changes
Mar 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎈 LGTM 🎈
SGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Move code to pkg:
Motivation
Facilitate maintenance and contributions.
By separating the code from the "non-code" it is easier to contribute: it puts forward the doc, the contrib file, scripts, proto, ...
This a clear separation between
cmd
and the main code.This will allow us to migrate the integration testing framework more easily without having to use build tags.
And lot of more things.
This type of structure tends to become a standard in GoLang for large projects.
More