Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move code to pkg #4596

Merged
merged 4 commits into from Mar 15, 2019
Merged

Move code to pkg #4596

merged 4 commits into from Mar 15, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Mar 14, 2019

What does this PR do?

Move code to pkg:

.
├── .git
├── .github
├── .semaphoreci
├── .travis
├── autogen
├── cmd
├── contrib
├── dist
├── docs
├── examples
├── integration
├── old
├── pkg
├── script
├── static
├── vendor
└── webui

Motivation

Facilitate maintenance and contributions.

By separating the code from the "non-code" it is easier to contribute: it puts forward the doc, the contrib file, scripts, proto, ...

This a clear separation between cmd and the main code.

This will allow us to migrate the integration testing framework more easily without having to use build tags.

And lot of more things.

This type of structure tends to become a standard in GoLang for large projects.

More

  • Added/updated tests
  • Added/updated documentation

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎈 LGTM 🎈

@mpl
Copy link
Collaborator

mpl commented Mar 15, 2019

SGTM

@traefiker traefiker merged commit f1b085f into traefik:master Mar 15, 2019
@ldez ldez deleted the feature/move-code branch March 15, 2019 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants