Fix response modifier initial building #4719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
area/middleware
kind/bug/fix
ldez
added
contributor/waiting-for-corrections
and removed
contributor/waiting-for-corrections
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the middleware names passed as argument to the response modifier middleware Builder. The Builder Build method is expecting qualified names (prefixed with the provider type), so that it can check their existence in the configs map. Before this change, the Build method was receiving non-prefixed names, so the middleware names were never found in the configs map.
Motivation
While investigating #4708 we found out that custom response headers supposedly added with the response modifier middleware never seemed to actually show up in the responses.
More
Added/updated documentationAdditional Notes
Co-authored-by: Ludovic Fernandez ldez@users.noreply.github.com