Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove authentication hashes from API #4918

Merged
merged 1 commit into from May 29, 2019

Conversation

Projects
None yet
6 participants
@ldez
Copy link
Member

commented May 29, 2019

What does this PR do?

Remove authentication hashes from API.

Motivation

Fixes #4917

More

  • Added/updated tests
  • Added/updated documentation
@juliens
Copy link
Member

left a comment

LGTM

@geraldcroes
Copy link
Contributor

left a comment

LGTM

@dduportal
Copy link
Contributor

left a comment

LGTM 👍

curl -u "user:password" http://localhost/api
{"docker":{"backends":{"backend-lb-api-auth-docker":{"servers":{"server-api-auth-lb-1-d8fc85de92d156719b52117aae5c7e4e":{"url":"http://172.22.0.2:8080","weight":1}},"loadBalancer":{"method":"wrr"}}},"frontends":{"frontend-docker-lb-api-auth-docker":{"entryPoints":["http"],"backend":"backend-lb-api-auth-docker","routes":{"route-frontend-docker-lb-api-auth-docker":{"rule":"Host:localhost"}},"passHostHeader":true,"priority":0,"basicAuth":null,"auth":{"basic":{}}}}}}
@dtomcej
Copy link
Member

left a comment

LGTM
:shipit:

@dduportal

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

FWIW, Web Ui impact:

After:

Capture d’écran 2019-05-29 à 19 11 32

Before:

Capture d’écran 2019-05-29 à 19 14 30

@traefiker traefiker merged commit 51287d9 into containous:v1.7 May 29, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
semaphoreci The build passed on Semaphore.
Details

@traefiker traefiker referenced this pull request May 29, 2019

Closed

Authentication hashes are available through the API #4917

1 of 2 tasks complete

@ldez ldez deleted the ldez:fix/auth-users branch May 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.