Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kubernetes id name #5383

Merged
merged 2 commits into from Sep 13, 2019
Merged

Fix kubernetes id name #5383

merged 2 commits into from Sep 13, 2019

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Sep 13, 2019

What does this PR do?

This PR replace / by - for ID in kubernetes providers to be able to navigate easily in the webui

Motivation

Be able to navigate in the webui

More

  • Added/updated tests
  • Added/updated documentation

@mmatur mmatur added kind/enhancement a new or improved feature. status/2-needs-review kind/bug/fix a bug fix labels Sep 13, 2019
@mmatur mmatur added this to the 2.0 milestone Sep 13, 2019
@mmatur mmatur added this to To review in v2 via automation Sep 13, 2019
@mmatur mmatur force-pushed the fix/kubernetes-crd-id branch 2 times, most recently from d598498 to e28052f Compare September 13, 2019 17:59
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 255e88f into traefik:v2.0 Sep 13, 2019
v2 automation moved this from To review to Done Sep 13, 2019
@mmatur mmatur deleted the fix/kubernetes-crd-id branch September 13, 2019 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants